git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v1] travis-ci: build and test Git on Windows

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 23, 2017, 19:15 UTC
Message-ID
<xmqq7f3fdcsx.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20170323180134.geoyvq7qbm5vujo6@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> I think both Junio and I have access to the Travis config. Travis does
> have a "this is secret" flag for setup config. But I think we'd need to
> verify that running the Travis build does not leak the variable in any
> other way.

I am not sure if I want to "Authorize application" at the GitHub site to give Travis that broad set of permissions, though. That is why I do not "log in with GitHub" to Travis.

I just logged into Travis and it seems to me that git/git is set to build branch updates (which sounds sensible) and also is set to build pull request updates. That somehow sounds like a dangerous mix with the "secret environment variables" thing, at least to me.

> For instance, if it's in the environment, can I push up a branch that
> does "set | grep GFW_CI_TOKEN", open a PR, and see it? I don't know the
> answer.
Previous: Samuel LijinNext: Lars Schneider
Message 22 of 24 in “travis-ci: build and test Git on Windows”
  1. travis-ci: build and test Git on WindowsLars Schneider, Mar 22, 2017
  2. Johannes SchindelinMar 22, 2017
  3. Lars SchneiderMar 23, 2017
  4. Junio C HamanoMar 22, 2017
  5. Johannes SchindelinMar 23, 2017
  6. Jeff KingMar 23, 2017
  7. Junio C HamanoMar 23, 2017
  8. Jeff KingMar 23, 2017
  9. Lars SchneiderMar 23, 2017
  10. Junio C HamanoMar 23, 2017
  11. Lars SchneiderMar 23, 2017
  12. Junio C HamanoMar 23, 2017
  13. Jeff KingMar 23, 2017
  14. Lars SchneiderMar 23, 2017
  15. Jeff KingMar 23, 2017
  16. Junio C HamanoMar 23, 2017
  17. Jeff KingMar 23, 2017
  18. Lars SchneiderMar 23, 2017
  19. Jeff KingMar 23, 2017
  20. Johannes SchindelinMar 24, 2017
  21. Samuel LijinMar 23, 2017
  22. Junio C HamanoMar 23, 2017
  23. Lars SchneiderMar 23, 2017
  24. Junio C HamanoMar 23, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.