Re: [PATCH v1] travis-ci: build and test Git on Windows
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 23, 2017, 20:10 UTC
- Message-ID
- <xmqqfui3bvpe.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <81C8DFC7-53DA-4533-8005-F6D8D643FDA2@gmail.com>
Lars Schneider <larsxschneider@gmail.com> writes:
Show 11 quoted lines
>>> I agree it's not ideal. But I think it is an improvement to check >>> pu/next/master/maint continuously :-) >> >> I am not sure what you mean. We are building each and every branch >> updates already, and I do not see any improvement over what we are >> doing now. Care to elaborate? > > We are building each and every branch on TravisCI right now - but > only on Linux and OSX. With this change we also build it on > Windows. That should help to spot Windows related issues more > quickly I think.
We are losing the build for PR for folks who later submit patches as the price for that. "building each and every branch" stay constant and the trade-off is between building four integration branches on Windows and allowing contributors to easily check their work early.
If your "But I think it is an improvement" was followed by "to check the four branches on Windows continuously", though, I wouldn't have had to ask the question, as I tend to agree it is a better trade off.
Thanks.