Re: [PATCH v1] travis-ci: build and test Git on Windows

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 23, 2017, 20:16 UTC
Message-ID: <xmqqbmsrbvf3.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170322065612.18797-1-larsxschneider@gmail.com>

Lars Schneider <larsxschneider@gmail.com> writes:

> Things, that would need to be done:
> * Someone with write access to https://travis-ci.org/git/git would need
>   to add the secret token as "GFW_CI_TOKEN" variable in the TravisCI
>   repository setting [1]. Afterwards the build should just work.

As coordinating the timing of when this happens with the timing when merging this topic to 'pu' happens is an unnecessary cognitive burden, can you make a small change to this part:

> +      script:
> +        - >
> +          test "$TRAVIS_REPO_SLUG" != "git/git" ||

Add
	test -z "$GFW_CI_TOKEN" ||

here, so that the sript is not run while "Someone with write access" hasn't got around to doing it.

> +          ci/run-windows-build.sh $GFW_CI_TOKEN $TRAVIS_BRANCH $(git rev-parse HEAD)

It would still be a good idea to dq all these $VARIABLE and $(COMMAND OUTPUT) references, as the script expects three parameters.

> + ...
> +[ $# -eq 3 ] || (echo "Unexpected number of parameters" && exit 1)

Thanks.