Re: [GSoC][PATCH v3 11/13] rebase--interactive: remove unused modes and functions

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 10, 2018, 22:36 UTC
Message-ID: <xmqqzhyy4t2f.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180710121557.6698-12-alban.gruin@gmail.com>

Alban Gruin <alban.gruin@gmail.com> writes:

Show 5 quoted lines

> This removes the modes `--skip-unnecessary-picks`, `--append-todo-help`,
> `--checkout-onto`, `--shorten-ids` and `--expand-ids` from
> rebase--helper.c, the functions of git-rebase--interactive.sh that were
> rendered useless by the rewrite of complete_action(), and
> append_todo_help_to_file() from rebase-interactive.c.

Good. So far up to this step, I thnk the organization of the series looks good, even if the execution in each individual step we have seen previously may still need to be improved.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.