From: Junio C Hamano Date: Tue, 10 Jul 2018 22:36:08 GMT Subject: Re: [GSoC][PATCH v3 11/13] rebase--interactive: remove unused modes and functions Message-ID: In-Reply-To: <20180710121557.6698-12-alban.gruin@gmail.com> Alban Gruin writes: > This removes the modes `--skip-unnecessary-picks`, `--append-todo-help`, > `--checkout-onto`, `--shorten-ids` and `--expand-ids` from > rebase--helper.c, the functions of git-rebase--interactive.sh that were > rendered useless by the rewrite of complete_action(), and > append_todo_help_to_file() from rebase-interactive.c. Good. So far up to this step, I thnk the organization of the series looks good, even if the execution in each individual step we have seen previously may still need to be improved.