Re: [GSoC][PATCH v3 05/13] sequencer: add a new function to silence a command, except if it fails
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 10, 2018, 18:13 UTC
- Message-ID
- <xmqqpnzv6jsn.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20180710121557.6698-6-alban.gruin@gmail.com>
Alban Gruin <alban.gruin@gmail.com> writes:
Show 12 quoted lines
> This adds a new function, run_command_silent_on_success(), to > redirect the stdout and stderr of a command to a strbuf, and then to run > that command. This strbuf is printed only if the command fails. It is > functionnaly similar to output() from git-rebase.sh. > > run_git_commit() is then refactored to use of > run_command_silent_on_success(). > > Signed-off-by: Alban Gruin <alban.gruin@gmail.com> > --- > sequencer.c | 51 +++++++++++++++++++++++++-------------------------- > 1 file changed, 25 insertions(+), 26 deletions(-)
Looks good to me; it seems to cover the glitches pointed out in the previous round well.