Re: [GSoC][PATCH v3 07/13] rebase -i: rewrite checkout_onto() in C

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 10, 2018, 18:22 UTC
Message-ID: <xmqqh8l76je4.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180710121557.6698-8-alban.gruin@gmail.com>

Alban Gruin <alban.gruin@gmail.com> writes:

Show 7 quoted lines

> This rewrites checkout_onto() from shell to C.
>
> A new command (“checkout-onto”) is added to rebase--helper.c. The shell
> version is then stripped.
>
> Signed-off-by: Alban Gruin <alban.gruin@gmail.com>
> ---

The only change relative to the previous round seems to be that this round does not pass verbose flag as a separate parameter, but reuses the opts.verbose field where "struct replay_opts" is being passed around.

Looks OK from a quick scan so far.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.