Re: [PATCH v2 5/5] t9902: avoid using the branch name `master`
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 21, 2020, 22:35 UTC
- Message-ID
- <xmqqzh5idah8.fsf@gitster.c.googlers.com>
- In-Reply-To
- <c2c1238b5d9dde684d100fa99437a813140cd615.1600725687.git.gitgitgadget@gmail.com>
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 9 quoted lines
> From: Johannes Schindelin <johannes.schindelin@gmx.de> > > The completion tests used that name unnecessarily, and it is a > non-inclusive term, so let's avoid using it here. > > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> > --- > t/t9902-completion.sh | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-)
Here, the tests and the tested feature do not work any differently on the first-made branch, so the same "just use topic, not the first-made branch name" used in 3/5 applies here.
Luckily, unlike 3/5 and 4/5, this step does not involve names derived from the name of the first-made branch name, so 'main' may be OK as-is, but for consistency across the patches, we may want to consider using 'topic' here as well. I dunno.