Re: [PATCH v2 4/5] tests: avoid variations of the `master` branch name
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Sep 26, 2020, 04:20 UTC
- Message-ID
- <nycvar.QRO.7.76.6.2009260619260.50@tvgsbejvaqbjf.bet>
- In-Reply-To
- <xmqq4knqep8t.fsf@gitster.c.googlers.com>
Hi Junio,
On Mon, 21 Sep 2020, Junio C Hamano wrote:
Show 19 quoted lines
> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
> > diff --git a/t/t3427-rebase-subtree.sh b/t/t3427-rebase-subtree.sh
> > index 79e43a370b..ba27e9d603 100755
> > --- a/t/t3427-rebase-subtree.sh
> > +++ b/t/t3427-rebase-subtree.sh
> > @@ -15,12 +15,12 @@ commit_message() {
> > # this test script tries to document them. First, the following commit history
> > # is generated (the onelines are shown, time flows from left to right):
> > #
> > -# master1 - master2 - master3
> > +# main1 - main2 - main3
>
> The improvement between v1 and v2 made to t3200 (the previous step)
> would equally apply here, no? IOW, master1 didn't have to have a
> name derived from master but could just have been called topic-1.
> So replacing master[0-9] with topoic[0-9] may be more appropriate
> here.Indeed. It also has the benefit that `topic-` has exactly the same amount of letters as `master`, therefore we need not worry about any ASCII art that is modified (and might need realigning).
Thanks, Dscho