Re: [PATCH 2/5] t/test-terminal: avoid non-inclusive language
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 16, 2020, 21:05 UTC
- Message-ID
- <xmqqft7hwhyd.fsf@gitster.c.googlers.com>
- In-Reply-To
- <3b4ae48d4a3a7e2d6aae259ead19b6643d2533e8.1600279853.git.gitgitgadget@gmail.com>
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Johannes Schindelin <johannes.schindelin@gmx.de> > > In the ongoing effort to make the Git project a more inclusive place, > let's try to avoid names like "master" where possible.
The two sides of a PTY are called 'master' and 'slave', and I understand there is a push to move away from these words, but calling one side with an invented name that is used by nobody else in the context of talking about PTY, while keeping the word used to call the other side, would lead to confusion.
A better change is to drop "master_" altogether without replacing the word with anything, and call them just "input", "output" and "error". For those who implement the PTY, calling both ends of the pipe 'master' vs 'slave' may be useful for them, as they are terms of art they are used to think with. But as end-users of PTY, the fact that we are holding the 'master' end, and access to the 'slave' end is done by asking the 'master' end we hold for the corresponding 'slave', is not that important. What each of these three PTYs is used for is much more important.
If $input, $output, and $error are too terse, spell them out as $term_input, $term_output and $term_error or something like that, perhaps.
Thanks.