Re: [PATCH v2 12/22] tree-diff.c: move S_DIFFTREE_IFXMIN_NEQ define from cache.h

From: Junio C Hamano <gitster@pobox.com>
Date: May 1, 2023, 16:46 UTC
Message-ID: <xmqqzg6o579h.fsf@gitster.g>
In-Reply-To: <230501.86zg6ohuw7.gmgdl@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

Show 9 quoted lines

>> +#define S_DIFFTREE_IFXMIN_NEQ	0x80000000
>> +
>>  /*
>>   * internal mode marker, saying a tree entry != entry of tp[imin]
>>   * (see ll_diff_tree_paths for what it means there)
>
> As it's only used in tree-diff.c, should this change not be instead
> changing how we define S_IFXMIN_NEQ itself, and combining the two
> comments seen here (the latter only partially, in the context).

Yup, the end result should look cleaner with this extra bit of tweak. Thanks for carefully reading the patch.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.