Re: [PATCH 00/23] Header cleanups (more splitting of cache.h and simplifying a few other deps)

From: Elijah Newren <newren@gmail.com>
Date: Apr 18, 2023, 02:41 UTC
Message-ID: <CABPp-BE4dsPc0u7D4mYtsQ6Ko-j1fOKfEwfmrpiCoAgvdG0AXA@mail.gmail.com>
In-Reply-To: <ce9ef1c6-23c1-2e9f-ed5f-3790e5ff3e1f@github.com>

On Mon, Apr 17, 2023 at 2:07 PM Derrick Stolee <derrickstolee@github.com> wrote:

Show 16 quoted lines

>
> On 4/15/2023 11:03 PM, Elijah Newren via GitGitGadget wrote:
> > This series continues to focus on splitting declarations from cache.h to
> > separate headers. This series also untangles some dependencies between
> > hash.h and repository.h, and between read-cache.c and tree.[ch], and cleans
> > up a few other headers. At the end of this series the number of cache.h
> > includes drops from 189 down to 149.
>
> Thank you for continuing to do this work.
>
> >  * Patch 14-16: move functions between hash<->repository and
> >    read-cache<->tree to simplify dependencies
>
> My only comment was on patch 14, where I'm not sure I like the methods
> moving from hash.h to repository.h. If we can find an alternative, that
> would make me happy.

I'm not aware of one, but I tried to deviously nerd snipe an expert on cleaning up compatibility macros for the_repository to see if he might have any bright ideas. :-)

Also, if you have any other ideas that might work, I'm all ears.

> The rest of the series looked very good.

Thanks for taking a look!