Re: [PATCH v2 00/22] Header cleanups (more splitting of cache.h and simplifying a few other deps)
- From
Glen Choo <chooglen@google.com>
- Date
- Apr 26, 2023, 17:54 UTC
- Message-ID
- <kl6lbkjao7fe.fsf@chooglen-macbookpro.roam.corp.google.com>
- In-Reply-To
- <pull.1517.v2.git.1682194649.gitgitgadget@gmail.com>
"Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 5 quoted lines
> This series continues to focus on splitting declarations from cache.h to > separate headers. This series also untangles some dependencies between > hash.h and repository.h, and between read-cache.c and tree.[ch], and cleans > up a few other headers. At the end of this series the number of cache.h > includes drops from 189 down to 149.
I looked over all of the patches briefly and didn't spot any issues, though not deeply enough for a Reviewed-by.
FWIW I am quite happy with the direction of this series. I find the result much easier to understand compared to the cache.h status quo.