Re: [PATCH 00/23] Header cleanups (more splitting of cache.h and simplifying a few other deps)

From: Derrick Stolee <derrickstolee@github.com>
Date: Apr 17, 2023, 21:07 UTC
Message-ID: <ce9ef1c6-23c1-2e9f-ed5f-3790e5ff3e1f@github.com>
In-Reply-To: <pull.1517.git.1681614205.gitgitgadget@gmail.com>

On 4/15/2023 11:03 PM, Elijah Newren via GitGitGadget wrote:

Show 5 quoted lines

> This series continues to focus on splitting declarations from cache.h to
> separate headers. This series also untangles some dependencies between
> hash.h and repository.h, and between read-cache.c and tree.[ch], and cleans
> up a few other headers. At the end of this series the number of cache.h
> includes drops from 189 down to 149.

Thank you for continuing to do this work.

>  * Patch 14-16: move functions between hash<->repository and
>    read-cache<->tree to simplify dependencies

My only comment was on patch 14, where I'm not sure I like the methods moving from hash.h to repository.h. If we can find an alternative, that would make me happy.

The rest of the series looked very good.

Thanks, -Stolee