Re: [PATCH v2 00/22] Header cleanups (more splitting of cache.h and simplifying a few other deps)
- From
Derrick Stolee <derrickstolee@github.com>
- Date
- Apr 24, 2023, 15:19 UTC
- Message-ID
- <1393c57f-9f3f-18da-8f02-badfdc62f02d@github.com>
- In-Reply-To
- <pull.1517.v2.git.1682194649.gitgitgadget@gmail.com>
On 4/22/2023 4:17 PM, Elijah Newren via GitGitGadget wrote:
Show 8 quoted lines
> Changes since v1: > > * dropped the 3rd patch (it was pulled into the series this one depends > upon to fix an issue in it) > * redid the old patch 14 (new patch 13); moved the parts of hash.h not > depending on repository.h into hash-ll.h so that other headers and files > could depend upon just that part. (Are people happy with the hash-ll.h > name or have alternate suggestions?)
Thank you for this change. I looked at patch 13 and was pleased to see several uses of hash-ll.h (more than I expected). I'm also happy with the name.
v2 LGTM.
Thanks, -Stolee