Re: [PATCH v2 00/22] Header cleanups (more splitting of cache.h and simplifying a few other deps)

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 26, 2023, 18:14 UTC
Message-ID: <xmqqsfcmse74.fsf@gitster.g>
In-Reply-To: <kl6lbkjao7fe.fsf@chooglen-macbookpro.roam.corp.google.com>

Glen Choo <chooglen@google.com> writes:

Show 13 quoted lines

> "Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
>> This series continues to focus on splitting declarations from cache.h to
>> separate headers. This series also untangles some dependencies between
>> hash.h and repository.h, and between read-cache.c and tree.[ch], and cleans
>> up a few other headers. At the end of this series the number of cache.h
>> includes drops from 189 down to 149.
>
> I looked over all of the patches briefly and didn't spot any issues,
> though not deeply enough for a Reviewed-by.
>
> FWIW I am quite happy with the direction of this series. I find the
> result much easier to understand compared to the cache.h status quo.

Anything that shrinks the kitchen-sinks would be good ;-)

Thanks.