Re: [PATCH] GIT-VERSION-GEN: Do not require tags to be annotated

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 10, 2013, 15:59 UTC
Message-ID: <xmqqy574zmzd.fsf@gitster.dls.corp.google.com>
In-Reply-To: <CAHGBnuN=vpJPXgd78aLohW3Awe+Y+0J7Bxwr4Fmn2NijMK1Z5g@mail.gmail.com>

Sebastian Schuberth <sschuberth@gmail.com> writes:

> Right, but do we really need DEF_VER *and* version? Couldn't we just
> package official source tarballs in a way that they already contain an
> auto-generated version file?

If you read our Makefile, you will see that we do include the version file in our official tarball with "make dist".

That however does not help those who use a tarball obtained from git-archive, perhaps via gitweb running at the distribution site.

Theoretically speaking, you can rip out everything but "version" and tell those who have been relying on the way other parts of G-V-G worked to change their workflow to stuff their favorite version string to that file before building, so in that sense, we do not *need* DEF_VER and version. But they have been there for a long time, and I do not think it gives us a good trade-off between risking regression and reducing the linecount to change it to remove one.