Re: [PATCH] GIT-VERSION-GEN: Do not require tags to be annotated

From: Sebastian Schuberth <sschuberth@gmail.com>
Date: Sep 7, 2013, 12:28 UTC
Message-ID: <CAHGBnuP6w8rvoz+h2Xase1ApY_kpZh4X=VF6LY4O0r7RS0UayA@mail.gmail.com>
In-Reply-To: <xmqqeh91wrvq.fsf@gitster.dls.corp.google.com>

On Fri, Sep 6, 2013 at 11:40 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 15 quoted lines

>> For custom builds of Git it sometimes is inconvenient to annotate tags
>> because there simply is nothing to say, so do not require an annotation.
>>
>> Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
>> ---
>
> Hmmmm, personally I'd actually want this to stay the way it is, or
> even require a valid signed tag, in order to make sure I won't
> mistakenly creating a lightweight tag.
>
> If you want to give build a custom name,
>
>     echo buildname >version
>
> should be sufficient, no?

That's not sufficient if you care about a proper (automated) release workflow with your releases tagged.

> I dunno.

That's fine, I do not care too deeply about this. I just wanted to give this patch a try and see what others think. Feel free to drop it.

-- 
Sebastian Schuberth