git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] GIT-VERSION-GEN: Do not require tags to be annotated

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Sep 10, 2013, 09:53 UTC
Message-ID
<CAMP44s09-WavPg=X8xOaOWzWZvoW=D=wBr6L2FUfY7qNaS8j2Q@mail.gmail.com>
In-Reply-To
<CAHGBnuN=vpJPXgd78aLohW3Awe+Y+0J7Bxwr4Fmn2NijMK1Z5g@mail.gmail.com>

On Tue, Sep 10, 2013 at 3:06 AM, Sebastian Schuberth <sschuberth@gmail.com> wrote:

> On Sun, Sep 8, 2013 at 7:41 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 21 quoted lines
>>>> a case where you have your own tag that points at the exact version
>>>> as I tagged?  In such a case, do you have a preference on which tag
>>>
>>> No. I always carry patches on top.
>>
>> That answer sidesteps the real issue; which one would you prefer if
>> there are two or more tags?  "describe" updated with your patch
>> would consider both and I think it favours the annotated one over
>> lightweight.  If it matches the preferred order then G-V-N with you
>> patch would help your workflow; otherwise you would still need a
>> different way, e.g. making sure what you want it to use is always
>> used by doing the ">version" thing.
>
> My answer sidesteps the issue because you were explicitly offering the
> sidestep in you original question ;-) Anyway, in such a scenario I
> would probably prefer my own tag instead of upstream's tag, to be
> honest. So you're right that in this case my patch won't help. But
> like I said, the case is not valid for me as I will always carry
> patches on top, and other people might feel differently about which
> tag (annotated vs. lightweight) they prefer if both point to the same
> commit.
Indeed. I prefer it the other way; annotated takes precedence.
-- 
Felipe Contreras
Previous: Sebastian SchuberthNext: Junio C Hamano
Message 10 of 16 in “GIT-VERSION-GEN: Do not require tags to be annotated”
  1. GIT-VERSION-GEN: Do not require tags to be annotatedSebastian Schuberth, Sep 6, 2013
  2. Junio C HamanoSep 6, 2013
  3. Felipe ContrerasSep 7, 2013
  4. Sebastian SchuberthSep 7, 2013
  5. Junio C HamanoSep 7, 2013
  6. Sebastian SchuberthSep 7, 2013
  7. Junio C HamanoSep 8, 2013
  8. Felipe ContrerasSep 9, 2013
  9. Sebastian SchuberthSep 10, 2013
  10. Felipe ContrerasSep 10, 2013
  11. Junio C HamanoSep 10, 2013
  12. Sebastian SchuberthSep 10, 2013
  13. Felipe ContrerasSep 8, 2013
  14. Kyle J. McKaySep 6, 2013
  15. Sebastian SchuberthSep 7, 2013
  16. Felipe ContrerasSep 8, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.