Re: [PATCH] GIT-VERSION-GEN: Do not require tags to be annotated
- From
Felipe Contreras <felipe.contreras@gmail.com>
- Date
- Sep 10, 2013, 09:53 UTC
- Message-ID
- <CAMP44s09-WavPg=X8xOaOWzWZvoW=D=wBr6L2FUfY7qNaS8j2Q@mail.gmail.com>
- In-Reply-To
- <CAHGBnuN=vpJPXgd78aLohW3Awe+Y+0J7Bxwr4Fmn2NijMK1Z5g@mail.gmail.com>
On Tue, Sep 10, 2013 at 3:06 AM, Sebastian Schuberth <sschuberth@gmail.com> wrote:
> On Sun, Sep 8, 2013 at 7:41 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 21 quoted lines
>>>> a case where you have your own tag that points at the exact version >>>> as I tagged? In such a case, do you have a preference on which tag >>> >>> No. I always carry patches on top. >> >> That answer sidesteps the real issue; which one would you prefer if >> there are two or more tags? "describe" updated with your patch >> would consider both and I think it favours the annotated one over >> lightweight. If it matches the preferred order then G-V-N with you >> patch would help your workflow; otherwise you would still need a >> different way, e.g. making sure what you want it to use is always >> used by doing the ">version" thing. > > My answer sidesteps the issue because you were explicitly offering the > sidestep in you original question ;-) Anyway, in such a scenario I > would probably prefer my own tag instead of upstream's tag, to be > honest. So you're right that in this case my patch won't help. But > like I said, the case is not valid for me as I will always carry > patches on top, and other people might feel differently about which > tag (annotated vs. lightweight) they prefer if both point to the same > commit.
Indeed. I prefer it the other way; annotated takes precedence.
-- Felipe Contreras