Re: [PATCH] GIT-VERSION-GEN: Do not require tags to be annotated

From: Sebastian Schuberth <sschuberth@gmail.com>
Date: Sep 7, 2013, 12:26 UTC
Message-ID: <CAHGBnuMmm=tHdpcBpcY6Vro-un3g2JR1N6C=J-jSX8f-1b0UOw@mail.gmail.com>
In-Reply-To: <4065B5CE-7E81-41F3-B9DE-FDA05C43AAB0@gmail.com>

On Sat, Sep 7, 2013 at 12:34 AM, Kyle J. McKay <mackyle@gmail.com> wrote:

>> For custom builds of Git it sometimes is inconvenient to annotate tags
>> because there simply is nothing to say, so do not require an annotation.
>
> It's not that hard to add -m "" to the command line:

It's not hard to type those characters, but (for me) it's hard to remember that I have to do it.

> if you're just trying to avoid the editor or thinking up a message.  Is `-m
> ""` really that inconvenient?

Yes, to me it's inconvenient, but not that much. And I think passing an empty annotation like you suggest is even worse than not setting an annotation at all, because I would assume if an annotation is set it's not empty, and if it is, I would expect this to be a user error.

-- 
Sebastian Schuberth