Re: [PATCH] GIT-VERSION-GEN: Do not require tags to be annotated

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 6, 2013, 21:40 UTC
Message-ID: <xmqqeh91wrvq.fsf@gitster.dls.corp.google.com>
In-Reply-To: <522A36AA.3050701@gmail.com>

Sebastian Schuberth <sschuberth@gmail.com> writes:

Show 5 quoted lines

> For custom builds of Git it sometimes is inconvenient to annotate tags
> because there simply is nothing to say, so do not require an annotation.
>
> Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
> ---

Hmmmm, personally I'd actually want this to stay the way it is, or even require a valid signed tag, in order to make sure I won't mistakenly creating a lightweight tag.

If you want to give build a custom name,

    echo buildname >version

should be sufficient, no?

I dunno.

Show 16 quoted lines

>  GIT-VERSION-GEN | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/GIT-VERSION-GEN b/GIT-VERSION-GEN
> index b444c18..68b61e3 100755
> --- a/GIT-VERSION-GEN
> +++ b/GIT-VERSION-GEN
> @@ -12,7 +12,7 @@ if test -f version
>  then
>  	VN=$(cat version) || VN="$DEF_VER"
>  elif test -d ${GIT_DIR:-.git} -o -f .git &&
> -	VN=$(git describe --match "v[0-9]*" --abbrev=7 HEAD 2>/dev/null) &&
> +	VN=$(git describe --tags --match "v[0-9]*" --abbrev=7 HEAD 2>/dev/null) &&
>  	case "$VN" in
>  	*$LF*) (exit 1) ;;
>  	v[0-9]*)