Re: [PATCH] GIT-VERSION-GEN: Do not require tags to be annotated

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Sep 8, 2013, 00:58 UTC
Message-ID: <CAMP44s3OyhHYv7JXf6UH1DnTWPTnD+15EZTnAmSvGb6BE1OdzQ@mail.gmail.com>
In-Reply-To: <CAJDDKr4JBeccwuD4PVq0ryO27Eyfz+yUAHT7xm0Dkh19SZpV4g@mail.gmail.com>

On Fri, Sep 6, 2013 at 11:30 PM, David Aguilar <davvid@gmail.com> wrote:

Show 22 quoted lines

>
> On Sep 6, 2013 7:51 PM, "Felipe Contreras" <felipe.contreras@gmail.com>
> wrote:
>>
>> Junio C Hamano wrote:
>> > Sebastian Schuberth <sschuberth@gmail.com> writes:
>> >
>> > > For custom builds of Git it sometimes is inconvenient to annotate tags
>> > > because there simply is nothing to say, so do not require an
>> > > annotation.
>> > >
>> > > Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
>> > > ---
>> >
>> > Hmmmm, personally I'd actually want this to stay the way it is, or
>> > even require a valid signed tag, in order to make sure I won't
>> > mistakenly creating a lightweight tag.
>>
>> So the only user Git should care about is you? If Git can make _you_ more
>> confortable not making certain mistakes, then that's the way it should be?
>
> Yes, certainly. Why would you think otherwise?

The whole purpose of a public software project is that it's useful to others.

Show 5 quoted lines

>> What's the point of lightweight tags anyway? 'git describe' doesn't use
>> them,
>> GIT-VERSION-GEN neither, just remove them already.
>
> RTFM

I don't see anything in the manual explaining why lightweight tags are useful, if all the Git tools just ignore them, and why the do that.

>> For the vast majority of the people out there, a tag is a tag. Period.
>
> Not for me. You are wrong.

You are not the vast majority, you are a single person.

-- 
Felipe Contreras