Re: [PATCH v5 5/6] rebase -i: support --ignore-date
Junio C Hamano <gitster@pobox.com> writes:
Show 16 quoted lines
> Rohit Ashiwal <rohit.ashiwal265@gmail.com> writes:
>
>> --ignore-date::
>> + Instead of using the given author date, reset it to the
>> + current time. This implies --force-rebase.
>
> The first sentence is unclear and puzzles me with "for what?". IOW,
> you are saying that by default the command uses the given (I presume
> that you meant what is recorded in the original commits being
> rebased---but we should find a way to explain it more clearly)
> author date, but with this option what is used is reset to the
> current time. It is left unspecified what the command is using that
> time for.
>
> Perhaps (I am writing this paragraph after writing the rest of the
> message, i.e. after reading the patch through):
Oops, too much re-editing without final proofreading. Sorry.
Show 5 quoted lines
> By default, the author date recorded in the commit being
> rebased as the author date is used as the author date of the
> rebased commits. The option tells Git to use the current
> timestamp as the author date of the rebased commits instead.
> This implies `--force-rebase`.
By default, the author date of the original commit is used
as the author date for the resulting commit. This option
tells Git to use the current timestamp instead and implies
`--force-rebase`.
would be much less redundant without losing clarity.