[PATCH v5 4/6] sequencer: rename amend_author to author_to_rename
- From
Rohit Ashiwal <rohit.ashiwal265@gmail.com>
- Date
- Nov 1, 2019, 14:00 UTC
- Message-ID
- <20191101140003.13960-5-rohit.ashiwal265@gmail.com>
- In-Reply-To
- <20191101140003.13960-1-rohit.ashiwal265@gmail.com>
The purpose of amend_author was to free() the malloc()'d string obtained from get_author() while amending a commit. But we can also use the variable to free() the author at our convenience. Rename it to convey this meaning.
Signed-off-by: Rohit Ashiwal <rohit.ashiwal265@gmail.com> --- sequencer.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sequencer.c b/sequencer.c index e2c324b3a6..34e45246f7 100644 --- a/sequencer.c +++ b/sequencer.c @@ -1353,7 +1353,7 @@ static int try_to_commit(struct repository *r, struct commit_extra_header *extra = NULL; struct strbuf err = STRBUF_INIT; struct strbuf commit_msg = STRBUF_INIT; - char *amend_author = NULL; + char *author_to_free = NULL; const char *hook_commit = NULL; enum commit_msg_cleanup_mode cleanup; int res = 0; @@ -1374,7 +1374,7 @@ static int try_to_commit(struct repository *r, strbuf_addstr(msg, orig_message); hook_commit = "HEAD"; } - author = amend_author = get_author(message); + author = author_to_free = get_author(message); unuse_commit_buffer(current_head, message); if (!author) { res = error(_("unable to parse commit author")); @@ -1473,7 +1473,7 @@ static int try_to_commit(struct repository *r, free_commit_extra_headers(extra); strbuf_release(&err); strbuf_release(&commit_msg); - free(amend_author); + free(author_to_free); return res; }
-- 2.21.0