Re: [PATCH v3 1/6] rebase -i: add --ignore-whitespace flag

From: Rohit Ashiwal <rohit.ashiwal265@gmail.com>
Date: Aug 20, 2019, 18:47 UTC
Message-ID: <CAL7ArXrNaCh9vbvNUuDVCsogT9c+j8J+TMts+nW+S7R2EKhiwA@mail.gmail.com>
In-Reply-To: <98aeebc5-fceb-1ce8-9c27-d425c3f6e674@gmail.com>

Hi Phillip

On Wed, Aug 21, 2019 at 12:10 AM Phillip Wood <phillip.wood123@gmail.com> wrote:

Show 6 quoted lines

>
> Thanks for spelling out exactly what this does. I had not appreciated
> the difference before. Does this mean that if I have a branch with some
> whitespace cleanups I'll get different results if I rebase it with the
> sequencer compared to am? (I suspect from the description that the
> sequencer will simply ignore all my whitespace changes)

I'm afraid that this is the case.

> I think this is ready if we can live with the difference - I'm not
> entirely convinced that adding an option with the same name and a
> different behavior is going to improve things though.

This is the first step to improving consistency. We can further improve upon the implementation. I have already mentioned that in the cover letter of previous patches[1].

Thanks Rohit

[1]: https://public-inbox.org/git/20190712185015.20585-1-rohit.ashiwal265@gmail.com/