Re: [GSoC][PATCH v2 5/6] rebase -i: support --ignore-date

From: Phillip Wood <phillip.wood123@gmail.com>
Date: Aug 17, 2019, 09:28 UTC
Message-ID: <8104c7e7-e29c-5a41-4097-55912dbe9fc5@gmail.com>
In-Reply-To: <xmqq8srv5ypo.fsf@gitster-ct.c.googlers.com>

On 14/08/2019 20:33, Junio C Hamano wrote:

Show 11 quoted lines

> Phillip Wood <phillip.wood123@gmail.com> writes:
> 
>> That's an important distinction, particularly if GIT_COMMITTER_DATE is
>> set in the environment - are we aiming to have the author and
>> committer dates match or are we just resetting the author date to now?
>> Rohit - do you know which --ignore-date does in the am based rebase?
> 
> The purpose "am --ignore-date" was to ignore "Date:" that came from
> the patch message, overriding it with the current date.  It might
> have become harder to read in the C version, but "git show v2.0.0:git-am.sh"
> would be an easier way to read how "--ignore-date" wanted to behave.

Thanks for the pointer, looking at the code I agree that --reset-author-date would be a better alias. If GIT_COMMITTER_DATE is not set then the author and committer dates match, otherwise the author date is reset to the current time. The code also shows how we should be combining --ignore-date and --committer-date-is-author-date.

Best Wishes

Phillip