Re: [GSoC][PATCH v2 5/6] rebase -i: support --ignore-date

From: Phillip Wood <phillip.wood123@gmail.com>
Date: Aug 14, 2019, 18:51 UTC
Message-ID: <c03439bf-54bf-b53d-9400-bdc4dd2a1309@gmail.com>
In-Reply-To: <xmqqblws7n8r.fsf@gitster-ct.c.googlers.com>

On 13/08/2019 22:45, Junio C Hamano wrote:

Show 14 quoted lines

> Rohit Ashiwal <rohit.ashiwal265@gmail.com> writes:
> 
>>   --ignore-date::
>> -	This flag is passed to 'git am' to change the author date
>> -	of the rebased commits (see linkgit:git-am[1]).
>> +	Instead of using the given author date, re-set it to the value
>> +	same as committer (current) date. This implies --force-rebase.
> 
> s/to the value same as .* date\./the current time./;
> 
> The more important thing is that we record the current timestamp as
> the author date; that timestamp being very close to the committer
> date of the resulting commit is a mere consequence of the fact that
> we use the current time for committer date and much less important.

That's an important distinction, particularly if GIT_COMMITTER_DATE is set in the environment - are we aiming to have the author and committer dates match or are we just resetting the author date to now? Rohit - do you know which --ignore-date does in the am based rebase?

Best Wishes

Phillip

> 
> Again, I think reset-author-date would be a better synonym to this
> one.
>