Re: [PATCH v5 6/6] rebase: add --reset-author-date

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 2, 2019, 07:34 UTC
Message-ID: <xmqq5zk23f5d.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20191101140003.13960-7-rohit.ashiwal265@gmail.com>

Rohit Ashiwal <rohit.ashiwal265@gmail.com> writes:

Show 17 quoted lines

>  --ignore-date::
> +--reset-author-date::
>  	Instead of using the given author date, reset it to the
>  	current time. This implies --force-rebase.
>  +
> diff --git a/builtin/rebase.c b/builtin/rebase.c
> index 7edae668f8..edefdd016b 100644
> --- a/builtin/rebase.c
> +++ b/builtin/rebase.c
> @@ -1455,6 +1455,8 @@ int cmd_rebase(int argc, const char **argv, const char *prefix)
>  		OPT_BOOL(0, "committer-date-is-author-date",
>  			 &options.committer_date_is_author_date,
>  			 N_("make committer date match author date")),
> +		OPT_BOOL(0, "reset-author-date", &options.ignore_date,
> +			 "ignore author date and use current date"),
>  		OPT_BOOL(0, "ignore-date", &options.ignore_date,
>  			 "ignore author date and use current date"),

One of them should say it is a mere synonym to the other (or hide from the "git rebase -h" listing altogether). Otherwise readers would be puzzled what the difference between the two are.

Thanks.