Re: [PATCH v2] blame: report correct number of lines in progress when using ranges

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 4, 2022, 19:32 UTC
Message-ID: <xmqqy20kprth.fsf@gitster.g>
In-Reply-To: <CAOc6etaY8enMF0nmhaqA2+Oi6JmYFY-bPqsUFTXE=K8aFoXDnQ@mail.gmail.com>

Edmundo Carmona Antoranz <eantoranz@gmail.com> writes:

Show 22 quoted lines

> On Mon, Apr 4, 2022 at 8:21 PM Edmundo Carmona Antoranz
> <eantoranz@gmail.com> wrote:
>>
>> When using ranges, use their sizes as the limit for progress
>> instead of the size of the full file.
>>
>>  '
>>
>> +test_expect_success 'blame progress on a full file' '
>> +       cat >progress.txt <<-\EOF &&
>> +       a simple test file
>> +
>> +       no relevant content is expected here
>> +
>> +       If the file is too short, we cannot test ranges
>> +
>> +       EOF
>> +       git add progress.txt &&
>> +       git commit -m "add a file for testing progress" &&
>
> I wonder if the preceding section should be kept in a
> separate 'setup test'?

I actually wonder why we need a *new* test file to run this test, instead of reusing what we already use in the existing test.

>
>> +       GIT_PROGRESS_DELAY=0 \
>> +       git blame --progress progress.txt > /dev/null 2> full_progress.txt &&

Style:

	git blame --progress progress.txt >/dev/null 2>full_progress.txt &&