Re: [PATCH v2] blame: report correct number of lines in progress when using ranges

From: Edmundo Carmona Antoranz <eantoranz@gmail.com>
Date: Apr 4, 2022, 18:25 UTC
Message-ID: <CAOc6etaY8enMF0nmhaqA2+Oi6JmYFY-bPqsUFTXE=K8aFoXDnQ@mail.gmail.com>
In-Reply-To: <20220404182129.33992-1-eantoranz@gmail.com>

On Mon, Apr 4, 2022 at 8:21 PM Edmundo Carmona Antoranz <eantoranz@gmail.com> wrote:

Show 17 quoted lines

>
> When using ranges, use their sizes as the limit for progress
> instead of the size of the full file.
>
>  '
>
> +test_expect_success 'blame progress on a full file' '
> +       cat >progress.txt <<-\EOF &&
> +       a simple test file
> +
> +       no relevant content is expected here
> +
> +       If the file is too short, we cannot test ranges
> +
> +       EOF
> +       git add progress.txt &&
> +       git commit -m "add a file for testing progress" &&

I wonder if the preceding section should be kept in a separate 'setup test'?

> +       GIT_PROGRESS_DELAY=0 \
> +       git blame --progress progress.txt > /dev/null 2> full_progress.txt &&
> +       grep "Blaming lines: 100% (6/6), done." full_progress.txt
> +'