Re: [PATCH v2] blame: report correct number of lines in progress when using ranges

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 6, 2022, 15:14 UTC
Message-ID: <xmqqsfqq1bx9.fsf@gitster.g>
In-Reply-To: <8622e48c-9f34-c644-4016-02c3795ac1e9@iee.email>

Philip Oakley <philipoakley@iee.email> writes:

Show 11 quoted lines

> On 05/04/2022 08:34, Bagas Sanjaya wrote:
>> On 05/04/22 01.21, Edmundo Carmona Antoranz wrote:
>>> When using ranges, use their sizes as the limit for progress
>>> instead of the size of the full file.
>>
>> The progress limit is defined by number of affected lines, right?
>
> I'd also wondered about 'their', thinking it was 'the files', rather
> than 'the ranges' [within those files].
>
> perhaps: s/their/range/

I actually think that it is obvious that "their" refers to the ranges and not the file. Between "the ranges" and "the file", only the former is plural that "their" could possibly refer to. Also, "instead ... the full file" makes the sentence nonsensical if it referred to the "file"---"we must use the number of lines in the file, instead of the number of lines in the file" simply would not make much sense.

But I do not object to being more explicit.

> "When using ranges, use the range sizes as the limit for progress' ..