Re: [PATCH v2] blame: report correct number of lines in progress when using ranges

From: Philip Oakley <philipoakley@iee.email>
Date: Apr 8, 2022, 08:03 UTC
Message-ID: <9920b355-9003-e7c7-77ab-3432651674e9@iee.email>
In-Reply-To: <xmqqsfqq1bx9.fsf@gitster.g>

On 06/04/2022 16:14, Junio C Hamano wrote:

Show 18 quoted lines

> Philip Oakley <philipoakley@iee.email> writes:
>
>> On 05/04/2022 08:34, Bagas Sanjaya wrote:
>>> On 05/04/22 01.21, Edmundo Carmona Antoranz wrote:
>>>> When using ranges, use their sizes as the limit for progress
>>>> instead of the size of the full file.
>>> The progress limit is defined by number of affected lines, right?
>> I'd also wondered about 'their', thinking it was 'the files', rather
>> than 'the ranges' [within those files].
>>
>> perhaps: s/their/range/
> I actually think that it is obvious that "their" refers to the
> ranges and not the file.  Between "the ranges" and "the file", only
> the former is plural that "their" could possibly refer to.  Also,
> "instead ... the full file" makes the sentence nonsensical if it
> referred to the "file"---"we must use the number of lines in the
> file, instead of the number of lines in the file" simply would not
> make much sense.

I'm on the 'context and guidelines' side of English comprehension, so it was all about files being blamed.

>
> But I do not object to being more explicit.

The core point though was that it can be misunderstood, thus avoiding the indirection, as you say, makes it more explicit for the reader.

>
>> "When using ranges, use the range sizes as the limit for progress' ..

-- Philip