Re: [PATCH 3/3] builtin/help.c: fix memory leak

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 10, 2015, 22:43 UTC
Message-ID: <xmqqwq2oxyli.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1425920304-22360-3-git-send-email-sbeller@google.com>

Stefan Beller <sbeller@google.com> writes:

Show 23 quoted lines

> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
>  builtin/help.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/builtin/help.c b/builtin/help.c
> index 6133fe4..a1f5a0a 100644
> --- a/builtin/help.c
> +++ b/builtin/help.c
> @@ -456,7 +456,7 @@ static void list_common_guides_help(void)
>  int cmd_help(int argc, const char **argv, const char *prefix)
>  {
>  	int nongit;
> -	const char *alias;
> +	char *alias;
>  	enum help_format parsed_help_format;
>  
>  	argc = parse_options(argc, argv, prefix, builtin_help_options,
> @@ -499,6 +499,7 @@ int cmd_help(int argc, const char **argv, const char *prefix)
>  	alias = alias_lookup(argv[0]);
>  	if (alias && !is_git_command(argv[0])) {
>  		printf_ln(_("`git %s' is aliased to `%s'"), argv[0], alias);
> +		free(alias);

Hmph, does this memory belong to us, or are we peeking into the cached data in the config cache layer?

>  		return 0;
>  	}