Re: [PATCH 2/3] bundle.c: fix memory leak

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 10, 2015, 22:40 UTC
Message-ID: <xmqq1tkwzdbj.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1425920304-22360-2-git-send-email-sbeller@google.com>

Stefan Beller <sbeller@google.com> writes:

> The continue statements nearby also have an accompanying free(ref);
>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---

I wonder what happens when dwim_ref() returned 2 or more, though.

Show 14 quoted lines

>  bundle.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/bundle.c b/bundle.c
> index 2e2dbd5..534783d 100644
> --- a/bundle.c
> +++ b/bundle.c
> @@ -342,6 +342,7 @@ static int write_bundle_refs(int bundle_fd, struct rev_info *revs)
>  		if (e->item->type == OBJ_TAG &&
>  				!is_tag_in_date_range(e->item, revs)) {
>  			e->item->flags |= UNINTERESTING;
> +			free(ref);
>  			continue;
>  		}