git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/3] builtin/help.c: fix memory leak

From
Stefan Beller <sbeller@google.com>
Date
Mar 9, 2015, 16:58 UTC
Message-ID
<1425920304-22360-3-git-send-email-sbeller@google.com>
In-Reply-To
<1425920304-22360-1-git-send-email-sbeller@google.com>
Signed-off-by: Stefan Beller <sbeller@google.com>
---
 builtin/help.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/builtin/help.c b/builtin/help.c
index 6133fe4..a1f5a0a 100644
--- a/builtin/help.c
+++ b/builtin/help.c
@@ -456,7 +456,7 @@ static void list_common_guides_help(void)
 int cmd_help(int argc, const char **argv, const char *prefix)
 {
 	int nongit;
-	const char *alias;
+	char *alias;
 	enum help_format parsed_help_format;
 
 	argc = parse_options(argc, argv, prefix, builtin_help_options,
@@ -499,6 +499,7 @@ int cmd_help(int argc, const char **argv, const char *prefix)
 	alias = alias_lookup(argv[0]);
 	if (alias && !is_git_command(argv[0])) {
 		printf_ln(_("`git %s' is aliased to `%s'"), argv[0], alias);
+		free(alias);
 		return 0;
 	}
 
-- 
2.3.0.81.gc37f363
Previous: Junio C HamanoNext: Junio C Hamano
Message 8 of 13 in “connect.c: Fix memory leak”
  1. 1/3 connect.c: Fix memory leakStefan Beller, Mar 9, 2015
  2. 2/3 bundle.c: fix memory leakStefan Beller, Mar 9, 2015
  3. Junio C HamanoMar 10, 2015
  4. Stefan BellerMar 10, 2015
  5. Junio C HamanoMar 10, 2015
  6. 2/3 bundle.c: fix memory leakStefan Beller, Mar 10, 2015
  7. Junio C HamanoMar 11, 2015
  8. 3/3 builtin/help.c: fix memory leakStefan Beller, Mar 9, 2015
  9. Junio C HamanoMar 10, 2015
  10. Stefan BellerMar 10, 2015
  11. Junio C HamanoMar 11, 2015
  12. Torsten BögershausenMar 9, 2015
  13. Junio C HamanoMar 10, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.