Re: [PATCH 3/3] builtin/help.c: fix memory leak

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 11, 2015, 03:52 UTC
Message-ID: <xmqqioe8ur50.fsf@gitster.dls.corp.google.com>
In-Reply-To: <CAGZ79kYSBsfbR_gH1Ur12vMpcK5S0K6wrOpMhNVvgffAb683Bw@mail.gmail.com>

Stefan Beller <sbeller@google.com> writes:

Show 11 quoted lines

>> Hmph, does this memory belong to us, or are we peeking into the
>> cached data in the config cache layer?
>
> So  alias_lookup(..) is a wrapper around git_config_string essentially
> (some more git_config_functions are involved, but we eventually reach
> git_config_string), where we have
>
>     *dest = xstrdup(value);
>
> so I think we need to free that memory, as the config cache layer doesn't
> care any more.

Ah, OK, thanks.