Re: [PATCH 1/3] connect.c: Fix memory leak
- From
Torsten Bögershausen <tboegi@web.de>
- Date
- Mar 9, 2015, 19:23 UTC
- Message-ID
- <54FDF34F.60608@web.de>
- In-Reply-To
- <1425920304-22360-1-git-send-email-sbeller@google.com>
On 2015-03-09 17.58, Stefan Beller wrote:
Show 18 quoted lines
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
> connect.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/connect.c b/connect.c
> index ce0e121..6090211 100644
> --- a/connect.c
> +++ b/connect.c
> @@ -739,6 +739,7 @@ struct child_process *git_connect(int fd[2], const char *url,
>
> free(hostandport);
> free(path);
> + free(conn);
> return NULL;
> } else {
> ssh = getenv("GIT_SSH_COMMAND");
> Nice catch, thanks. (Even if it is not sooo serious today, the current implementation of Git just dies when connection is NULL)