Re: [PATCH v2] transport-helper: enforce atomic in push_refs_with_push

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 19, 2019, 19:15 UTC
Message-ID: <xmqqwogdvnsx.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CAPUEsphnCvK+RZ+h30ZarA1zo9yZ=ndEBrcAbKGf4W92j647vA@mail.gmail.com>

Carlo Arenas <carenas@gmail.com> writes:

Show 12 quoted lines

> On Thu, Jul 18, 2019 at 6:31 PM Jonathan Nieder <jrnieder@gmail.com> wrote:
>>
>> This makes sense to me.  Not really for the 'for' loop declaration
>> aspect: for that, I'd want some more specialized tool that allows
>> turning on such a check specifically.  But more because Ubuntu trusty
>> is still a platform that some people use (though hopefully not for
>> long), so it's helpful as a representative old platform to see if we
>> break the build on it.
>
> FWIW this also breaks Centos 7 using gcc 4.8.5, as well as the one
> originally reported (Centos 6), and anything else that uses gcc 4
> (tested up to 4.9.4)

Thanks.