[PATCH] transport-helper: avoid var decl in for () loop control
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 16, 2019, 20:28 UTC
- Message-ID
- <xmqq36j53esa.fsf_-_@gitster-ct.c.googlers.com>
- In-Reply-To
- <xmqq8ssx53a0.fsf@gitster-ct.c.googlers.com>
We do allow a few selected C99 constructs in our codebase these days, but this is not among them (yet).
Reported-by: Carlo Arenas <carenas@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> --- transport.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/transport.c b/transport.c index d768bc275e..453de8f704 100644 --- a/transport.c +++ b/transport.c @@ -1227,7 +1227,8 @@ int transport_push(struct repository *r, ret = push_ret | err; if ((flags & TRANSPORT_PUSH_ATOMIC) && err) { - for (struct ref *it = remote_refs; it; it = it->next) + struct ref *it; + for (it = remote_refs; it; it = it->next) switch (it->status) { case REF_STATUS_NONE: case REF_STATUS_UPTODATE: