Re: [PATCH] transport-helper: enforce atomic in push_refs_with_push

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 2, 2019, 20:16 UTC
Message-ID: <xmqqk1d02nv5.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190702005340.66615-1-emilyshaffer@google.com>

Emily Shaffer <emilyshaffer@google.com> writes:

Show 11 quoted lines

> +		if ((flags & TRANSPORT_PUSH_ATOMIC) && err) {
> +			for (struct ref *it = remote_refs; it; it = it->next)
> +				switch (it->status) {
> +				case REF_STATUS_NONE:
> +				case REF_STATUS_UPTODATE:
> +				case REF_STATUS_OK:
> +					it->status = REF_STATUS_ATOMIC_PUSH_FAILED;
> +				default:
> +					continue;
> +				}
> +		}

Let's write this more like so

		if ((flags & TRANSPORT_PUSH_ATOMIC) && err) {
			for (struct ref *it = remote_refs; it; it = it->next)
				switch (it->status) {
				case REF_STATUS_NONE:
				case REF_STATUS_UPTODATE:
				case REF_STATUS_OK:
					it->status = REF_STATUS_ATOMIC_PUSH_FAILED;
					break;
				default:
					break;
				}
		}

to prevent compilers from giving "implicit fallthru" warnings.