Re: [PATCH v2] transport-helper: enforce atomic in push_refs_with_push

From: Carlo Arenas <carenas@gmail.com>
Date: Jul 16, 2019, 18:00 UTC
Message-ID: <CAPUEspjCXe4ga9HrF=RwGfP3Wc6Et4JW5ZG5thihgQTUQss77A@mail.gmail.com>
In-Reply-To: <xmqq8ssx53a0.fsf@gitster-ct.c.googlers.com>

On Tue, Jul 16, 2019 at 9:54 AM Junio C Hamano <gitster@pobox.com> wrote:

>
> Does everything else compile OK with your rather old compiler on
> Centos 6?

yes, they were a few -Wmaybe-uninitialized warnings but they were most likely false positives.

gcc 4.4.7 aborts the build (even without -Werror) with the following message: transport.c: In function 'transport_push': transport.c:1232: error: 'for' loop initial declarations are only allowed in C99 mode transport.c:1232: note: use option -std=c99 or -std=gnu99 to compile your code make: *** [transport.o] Error 1

Carlo

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.