Re: [PATCH] transport-helper: enforce atomic in push_refs_with_push
- From
Emily Shaffer <emilyshaffer@google.com>
- Date
- Jul 3, 2019, 00:09 UTC
- Message-ID
- <20190703000957.GB121233@google.com>
- In-Reply-To
- <xmqqk1d02nv5.fsf@gitster-ct.c.googlers.com>
On Tue, Jul 02, 2019 at 01:16:46PM -0700, Junio C Hamano wrote:
Show 31 quoted lines
> Emily Shaffer <emilyshaffer@google.com> writes:
>
> > + if ((flags & TRANSPORT_PUSH_ATOMIC) && err) {
> > + for (struct ref *it = remote_refs; it; it = it->next)
> > + switch (it->status) {
> > + case REF_STATUS_NONE:
> > + case REF_STATUS_UPTODATE:
> > + case REF_STATUS_OK:
> > + it->status = REF_STATUS_ATOMIC_PUSH_FAILED;
> > + default:
> > + continue;
> > + }
> > + }
>
>
> Let's write this more like so
>
> if ((flags & TRANSPORT_PUSH_ATOMIC) && err) {
> for (struct ref *it = remote_refs; it; it = it->next)
> switch (it->status) {
> case REF_STATUS_NONE:
> case REF_STATUS_UPTODATE:
> case REF_STATUS_OK:
> it->status = REF_STATUS_ATOMIC_PUSH_FAILED;
> break;
> default:
> break;
> }
> }
>
> to prevent compilers from giving "implicit fallthru" warnings.Done, thanks.