Re: [PATCH v3 0/3] compat/mingw: implement POSIX-style atomic renames

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 6, 2024, 03:54 UTC
Message-ID: <xmqqwmhhow3j.fsf@gitster.g>
In-Reply-To: <cover.1730042775.git.ps@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 18 quoted lines

> Hi,
>
> this is third version of my patch series that introduces POSIX-style
> atomic renames on Windows to fix concurrent writes with the reftable
> backend.
>
> Changes compared to v2:
>
>   - Use `DWORD` instead of `int` to store the `access` flags.
>
>   - Fix handling of `oflags`.
>
>   - Add a comment referring to `mingw_open_append()` for why convert
>     `ERROR_INVALID_PARAMETER` to `ERROR_PATH_NOT_FOUND`.
>
> Thanks!
>
> Patrick

Thanks, Patrick, for listing those who gave reviews on the previous iterations of these patches.

Reviewers, how does this round look to you? Is this a version you folks are comfortable to have in 'next' and later in 'master'?

Thanks.