Re: [PATCH 3/3] compat/mingw: support POSIX semantics for atomic renames

From: Taylor Blau <me@ttaylorr.com>
Date: Oct 23, 2024, 18:30 UTC
Message-ID: <ZxlAriZuYZNrOWJF@nand.local>
In-Reply-To: <d17ca1c7ce38e12fe113f15b078c12bc92e8f0aa.1729695349.git.ps@pks.im>

On Wed, Oct 23, 2024 at 05:05:03PM +0200, Patrick Steinhardt wrote:

> ---
>  compat/mingw.c             | 87 ++++++++++++++++++++++++++++++++++++--
>  t/t0610-reftable-basics.sh |  8 ++--
>  2 files changed, 88 insertions(+), 7 deletions(-)

All well reasoned and explained as usual. I'm glossing over the Windows-specific parts, though they look correct to me if I squint and pretend that I have even a passing familiarity with the platform ;-).

This looks good, and I am glad to hear that it was tested on Windows 8.1 by Johannes, and on Windows 10 by you. Do we have any reason to believe it would break on Vista? If so, should we test there as well?

Otherwise, this is looking good, modulo the handful of typos that was noticed earlier in the thread on this patch. Thanks to you and Johannes for working on this together!

Thanks, Taylor