Re: [PATCH v2 2/3] compat/mingw: allow deletion of most opened files

From: Taylor Blau <me@ttaylorr.com>
Date: Oct 27, 2024, 23:51 UTC
Message-ID: <Zx7R7R2xDXX0m0kU@nand.local>
In-Reply-To: <Zx7RU6sgIJjNSutE@nand.local>

On Sun, Oct 27, 2024 at 07:48:35PM -0400, Taylor Blau wrote:

Show 17 quoted lines

> It may be nice to write this as a switch statement, since we're always
> comparing the value of oflags & O_ACCMODE, like so:
>
>     switch (oflags & O_ACCMODE) {
>     case O_RDWR:
>         access = GENERIC_READ | GENERIC_WRITE;
>         break;
>     case O_WRONLY:
>         access = GENERIC_WRITE;
>         break;
>     default:
>         access = GENERIC_READ;
>         break;
>     }
>
> , but it is a minor point and I certainly do not have very strong
> feelings here.

...and I see that's exactly what you went with in the subsequent round ;-).

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.