Re: [PATCH 10/14] rust: add a build.rs script for tests

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 29, 2025, 23:12 UTC
Message-ID: <xmqqwm4d716i.fsf@gitster.g>
In-Reply-To: <CAH=ZcbBYRiceXQ-9FNq0aK0WzN4nDhqonaoafweStC37mx7JBA@mail.gmail.com>

Ezekiel Newren <ezekielnewren@gmail.com> writes:

Show 14 quoted lines

>> Hmm, I recall Ezekiel earlier arguing to roll reftable and xdiff
>> libraries into libgit.a as it is a lot more cumbersome to have to
>> link with multiple libraries (sorry, I may be misremembering and do
>> not have reference handy), but if the above is all it takes to link
>> with these, perhaps it is not such a huge deal?
>
> I think Brian might have written this before my series was merged in.
> ...
>> I am a bit confused.
>>
>> XDIFF_LIB and REFTABLE_LIB are gone from Makefile on 'master'
>> already.  Perhaps we should revert earlier series from him?
> ...
> I don't think we should revert my series.

The order of events does not really matter, does it?

If we can happily link with more than one libraries [*], it would give us a much more pleasant developer experience than having to roll everything into a single library archive, no? Or are you saying that the way this series links these multiple libraries somehow does not work?

You somehow manged to confuse me even more ... X-<.