Re: [PATCH 00/14] SHA-1/SHA-256 interoperability, part 2

From: Ezekiel Newren <ezekielnewren@gmail.com>
Date: Nov 20, 2025, 23:11 UTC
Message-ID: <CAH=ZcbAnnakV4RgMJdkJB4hL1HyfbmY07EF-axDbEY_=_tfmFQ@mail.gmail.com>
In-Reply-To: <aR-eIooTkjbktsf-@fruit.crustytoothpaste.net>

On Thu, Nov 20, 2025 at 4:03 PM brian m. carlson <sandals@crustytoothpaste.net> wrote:

Show 11 quoted lines

>
> On 2025-11-20 at 19:52:23, Ezekiel Newren wrote:
> > Checkout my retrospective review [1]. Basically if windows + msvc ->
> > <crate>.lib else lib<crate>.a, but it was coded as just if windows ->
> > ...
> >
> > In the github ci these are the only windows combos that are tested.
> > "win build" is windows + gnu + Makefile
> > "win+Meson build" windows + msvc + Meson
>
> So I don't think that fixes the build[0] with this patch:

You are correct. It's part of the whole solution. I'm working on ironing out all github ci problems in my cargo-workspace patch series (not yet released). Once I've figured that out I'll publish my series on the mailing list.