Re: [PATCH 03/14] hash: use uint32_t for object_id algorithm

From: Patrick Steinhardt <ps@pks.im>
Date: Oct 28, 2025, 09:16 UTC
Message-ID: <aQCKCfuaEKBArD-g@pks.im>
In-Reply-To: <20251027004404.2152927-4-sandals@crustytoothpaste.net>

On Mon, Oct 27, 2025 at 12:43:53AM +0000, brian m. carlson wrote:

> We currently use an int for this value, but we'll define this structure
> from Rust in a future commit and we want to ensure that our data types
> are exactly identical.  To make that possible, use a uint32_t for the
> hash algorithm.

An alternative would be to introduce an enum and set up bindgen so that we can pull this enum into Rust. I'd personally favor that over using an uint32_t as it conveys way more meaning. Have you considered this?

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.