Re: [PATCH 00/14] SHA-1/SHA-256 interoperability, part 2
- From
Ezekiel Newren <ezekielnewren@gmail.com>
- Date
- Nov 20, 2025, 19:52 UTC
- Message-ID
- <CAH=ZcbDER4OysywLZpCc=-GQ+rweSfVAQ-xj0gNd1rF4-=cPWg@mail.gmail.com>
- In-Reply-To
- <CAH=ZcbAmAqWMYXhYT3bX_Q8cEkV0ZcjEtM65YS7DXPJbs-L3Wg@mail.gmail.com>
On Wed, Nov 19, 2025 at 4:37 PM Ezekiel Newren <ezekielnewren@gmail.com> wrote:
Show 37 quoted lines
> > On Wed, Nov 19, 2025 at 4:04 PM brian m. carlson > <sandals@crustytoothpaste.net> wrote: > > > > On 2025-11-18 at 00:13:40, Junio C Hamano wrote: > > > Thanks. > > > > > > $ git log --oneline --first-parent -4 seen > > > 3f252ac9fe Merge branch 'ar/run-command-hook' into seen > > > 672cb7c62e ### CI > > > 3af201233b Merge branch 'bc/sha1-256-interop-02' into seen > > > 950efaac03 Merge branch 'cc/fast-import-strip-if-invalid' into seen > > > > > > It seems that 672cb7c62e (which is an empty commit on top of the > > > merge of v2 of this series) fails win+Meson > > > > > > https://github.com/git/git/actions/runs/19447841443/job/55646336507#step:6:689 > > > > > > but 950efaac03 (which is the merge before v2 of this series is > > > merged to 'seen') is happy with it. > > > > > > https://github.com/git/git/actions/runs/19448271167/job/55647611566 > > > > > > These two runs roughly corresponds to the with=bad/without=good pair > > > in the message you are reponding to, but with the v1 of this series. > > > > Yes, I think we'll need someone familiar with Windows to take a look at > > that. The message doesn't indicate anything obvious and I don't have > > any Windows systems available to investigate. > > > > My guess is that it's something to do with the build.rs file, but I'm > > not certain. > > This was a known issue, that I pointed out, before Patrick's > "Introduce Rust" series was merged in [1]. > > [1] https://lore.kernel.org/git/CAH=ZcbBjL09Mk3AXBSgmZGvmFtU3Roc2P5rbQsZ-U5DBHYSs7w@mail.gmail.com/
Checkout my retrospective review [1]. Basically if windows + msvc -> <crate>.lib else lib<crate>.a, but it was coded as just if windows -> ...
In the github ci these are the only windows combos that are tested. "win build" is windows + gnu + Makefile "win+Meson build" windows + msvc + Meson
[1] ci windows problems https://lore.kernel.org/git/CAH=ZcbB8cRgCTp-Q_CxJ4VFNY1+w+C20zgx9bMre4-hNmPrD7g@mail.gmail.com/