Re: [PATCH 09/14] hash: expose hash context functions to Rust

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Oct 30, 2025, 21:42 UTC
Message-ID: <aQPbsX-J4eKvRTar@fruit.crustytoothpaste.net>
In-Reply-To: <xmqqqzulacst.fsf@gitster.g>

On 2025-10-29 at 16:32:50, Junio C Hamano wrote:

Show 11 quoted lines

> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
> 
> > +struct git_hash_ctx *git_hash_alloc(void)
> > +{
> > +	return malloc(sizeof(struct git_hash_ctx));
> > +}
> 
> Not an objection, but this looked especially curious to me because
> it has been customary to use xmalloc() for a thing like this.  Going
> forward, is our intention that we'd explicitly handle OOM allocation
> failures ourselves, at least in the Rust part of the code base?

No, I'll change this to use `xmalloc`. Rust handles allocation itself and just panics on OOM, so we will not want to handle allocation failures ourselves.

-- 
brian m. carlson (they/them)
Toronto, Ontario, CA